SniperGold_ML/docs/SESSION_HANDOVER_2026-08-22_P3_S9_ARCHITECTURE_REVIEW.md

# SESSION HANDOVER — SNIPERGOLD_ML P3-S.9: CROSS-PRIMITIVE ARCHITECTURE REVIEW

```text
Date       : 2026-08-22 (session close)
Status     : P3-S.9 COMPLETE — evidence consolidated; architecture reviewed;
             repair plan specified; NOT yet committed (handover prepared
             before commit+push)
Forge      : https://forge.mql5.io/chiki2bum2/SniperGold_ML
Checkpoint : P3-S.6 533c8c6647a552d01a1a290cb2d0505f94887666 (VERIFIED at
             start; P3-S.7/P3-S.8 artifacts intact, uncommitted)
```

---

## 1. SESSION OBJECTIVE

```text
Consolidated architecture and repair-design review (NOT implementation).

Question answered:
  What should SniperGold consider to be ONE valid Candidate Setup, how
  should H4/M30/M15/M3 participate in creating it, and what existing code
  must change to implement that definition consistently?

Answer:
  ONE Candidate Setup = a discrete, causally-ordered entity on the M15
  entry layer: H4 context gate -> M30 context gate -> Liquidity EVENT ->
  CHoCH/MSS EVENT (after sweep) -> unmitigated OB|FVG ZONE -> M15 entry
  condition -> CANDIDATE_SETUP (M3 optional micro-confirmation). Identity,
  lifecycle, and per-stage validity windows are defined as design
  contracts.

ARCHITECTURE STATUS: B. DESIGN DECISION REQUIRED
  (the review is complete and actionable; owner adjudication of OD-1..OD-5
  is required before implementation — in particular the override of
  P3-S.7 S-N/S-C permissiveness and the canonical MTF model.)

No production code changed. No ML. No retraining. No optimization.
Human verification = CANCELLED.
```

---

## 2. CHECKPOINT & PROVENANCE (session start)

```text
Forge HEAD          : 533c8c6647a552d01a1a290cb2d0505f94887666 (P3-S.6)  VERIFIED
Branch / remote     : main == origin/main (SniperGold_ML.git)             VERIFIED
Working tree        : only the 12 P3-S.7/P3-S.8 artifacts untracked
                      (unchanged since P3-S.8)                            VERIFIED
P3-S.2..S.8 handovers : all 7 read (S.2 x2, S.3, S.4, S.5, S.6, S.7, S.8) VERIFIED
Human verification  : CANCELLED                                           VERIFIED
```

---

## 3. EVIDENCE CONSOLIDATION (master table, §5 of the brief)

```text
Sweep        : detection CONFORMING; consumer NON-CONFORMING (BUG-P3S2-001);
               PARTIALLY CONFORMING overall.
CHoCH/MSS    : detection CONFORMING; consumer NON-CONFORMING
               (BUG-P3S3-001); training pivot drift (BUG-P3S3-002);
               PARTIALLY CONFORMING overall.
FVG          : geometry CONFORMING; Engine-2 mitigation NON-CONFORMING
               (BUG-P3S4-001); timing (BUG-P3S4-002); PARTIALLY CONFORMING.
OB           : formation CONFORMING (current); mitigation NON-CONFORMING
               (BUG-P3S5-001); two definitions (A-2); PARTIALLY CONFORMING.
Displacement : CONFORMING; cross-concept constant 1.5 vs 1.6
               (BUG-P3S6-001, design decision).
MTF          : TF assignment/as-of CONFORMING; hierarchy NOT implemented
               (D-1); two MTF models (D-5); three models (D-6); same
               detector per-TF (D-7); PARTIALLY CONFORMING.
Candidate    : SPECIFICATION AMBIGUOUS -> RESOLVED AT DESIGN LEVEL in this
Setup        : session (D.1 proposal); D-8/D-9/D-10/D-11/D-12 documented.
```

Full table with citations: docs/P3_S9_ARCHITECTURE_REVIEW.md §B.

---

## 4. ROOT CAUSES (shared, not per-bug)

```text
A. Event/state confusion      (Sweep, CHoCH, CandSetup)
B. Zone/mitigation consumer   (FVG, OB, CandSetup)
C. Duplicate event emission   (Sweep, CHoCH, CandSetup)
D. Stale state consumption    (Sweep, CHoCH, FVG, OB, CandSetup)
E. Multiple definitions       (ALL)
F. Flat score as setup        (MTF, CandSetup)
G. Timeframe role drift       (MTF, CandSetup)
H. Training/runtime drift     (CHoCH, MTF)
I. Missing setup identity     (CandSetup)
J. Missing explicit lifecycle (Sweep, CHoCH, CandSetup)
-> docs/P3_S9_ROOT_CAUSE_MATRIX.md (evidence-cited matrix)
Dominant class: CONSUMER/CONTRACT layer, not detectors.
```

---

## 5. ARCHITECTURE DECISION

```text
OPTION A (recommended) — Hard Sequential Setup State Machine
  H4 -> M30 -> Liquidity -> CHoCH -> OB/FVG -> M15 Entry -> [M3 optional]
  -> ONE CANDIDATE SETUP (identity + lifecycle + per-stage windows).

OPTION B (evaluated, not recommended) — Hierarchical Candidate + optional
  confirmations (closest to the current E-rule; does not structurally solve
  identity/dedup/lifecycle/stale-consumption root causes).

Rejected: any "best of both" grab-bag (brief §21).

M3 is OPTIONAL per P3-S.7 S-P evidence (not made mandatory).
The flat vote is retained ONLY as signal-scoring on top of valid setups
(resolves D-9).
```

---

## 6. KEY DESIGN CONTRACTS (defined, NOT implemented)

```text
Setup identity : {setup_id, direction, sweep onset, choch onset, zone
                  (type+formation ts), entry TF, creation ts, M3 ts,
                  expiry/invalidation reason}; uniqueness is causal.
Lifecycle      : NONE -> CONTEXT_VALID -> LIQUIDITY_TRIGGERED ->
                 STRUCTURE_CONFIRMED -> ZONE_READY -> ENTRY_ARMED ->
                 CANDIDATE_SETUP -> [M3_CONFIRMED] -> EXPIRED /
                 INVALIDATED / CONSUMED. Transitions explicit; at most one
                 entry signal per setup; no reactivation.
Contracts      : EVENT {ts, dir, validity, superseded}; ZONE {bnd, dir,
                 mit_state, invalidated}; STATE {value, as_of}; ATTRIBUTE
                 {value_at_closed_bar}; CONDITION {in_zone, conf, as_of}.
Validity       : separate windows for sweep / choch / zone / confirmation /
                 setup (NOT one SeqWindow reused everywhere).
MTF            : H4/M30 context GATES; M15 chain; M3 optional; conflict ->
                 gate-fail (not arithmetic) for the setup layer.
```

---

## 7. CONSOLIDATED REPAIR PLAN (docs/P3_S9_CONSOLIDATED_REPAIR_PLAN.md)

```text
Master classification: 30 issues (BUG-P3S2-001..005, BUG-P3S3-001..003,
BUG-P3S4-001..004, BUG-P3S5-001..004, BUG-P3S6-001, D-1..D-14) ->
REPAIR / REDESIGN / DESIGN DECISION / DEPRECATE / DOCUMENT ONLY.

6 repair families:
  F1 EVENT/STATE contract (P1): BUG-P3S2-001, BUG-P3S3-001, D-12
  F2 ZONE contract (P1): BUG-P3S4-001/-002, BUG-P3S5-001
  F3 SETUP LAYER (P1/P2): D-8, D-9, D-10, D-11, D-1
  F4 MTF/TRAINING alignment (P2): D-2, D-3, D-5, D-6, BUG-P3S2-003,
     BUG-P3S3-002
  F5 DISPLAY (P2): D-4
  F6 DEFINITIONS/CLEANUP (P3): BUG-P3S5-002/-003/-004, BUG-P3S6-001, D-7,
     D-14, misc BUG-P3Sx-0xx
Priorities: P1 correctness -> P2 architecture -> P3 documentation.
```

---

## 8. OPEN DESIGN DECISIONS (owner adjudication required)

```text
OD-1 H4/M30 as hard context gates (overrides P3-S.7 S-N/S-C for the SETUP
     layer; vote retained for signal scoring).
OD-2 Canonical MTF model (H4/M30/M15/M3 for agent+setup vs legacy
     D1/H4/H1 for training).
OD-3 Validity window VALUES (W_sweep, W_choch, W_setup, zone max age).
OD-4 Conflict policy (context-compatible thresholds; M3 contrary handling).
OD-5 OB canonical definition + OB/displacement constant unification
     (1.5 vs 1.6).
```

---

## 9. NO PRODUCTION CHANGE

Only P3-S.9 artifacts added; 0 production files modified (verified:
git status shows only the P3-S.7/P3-S.8/P3-S.9 artifacts untracked; HEAD
unchanged at 533c8c6).

## 10. NEXT GATE

```text
ARCHITECTURE STATUS = DESIGN DECISION REQUIRED.
Next: owner/design adjudication of OD-1..OD-5, then a dedicated
IMPLEMENTATION phase (tests first, one repair family at a time, regression
+ parity + setup dataset rebuild). This implementation must NOT start until
the architecture is locked.
```

## 11. ARTIFACTS

```text
docs/P3_S9_ROOT_CAUSE_MATRIX.md
docs/P3_S9_ARCHITECTURE_REVIEW.md
docs/P3_S9_CONSOLIDATED_REPAIR_PLAN.md
docs/SESSION_HANDOVER_2026-08-22_P3_S9_ARCHITECTURE_REVIEW.md  (this document)
```

## 12. COMMIT & PUSH STATUS

```text
NOT YET COMMITTED at handover write time.
Planned message:
  research: P3-S.9 cross-primitive architecture review (DESIGN DECISION REQUIRED)
```