mirror of
https://github.com/A6-9V/MQL5-Google-Onedrive.git
synced 2026-04-11 04:20:57 +00:00
11856f63e8
This commit introduces two key performance and safety improvements to the repository's maintenance scripts: 1. **Optimize `scripts/test_automation.py`**: - Replaced `concurrent.futures.ProcessPoolExecutor` with sequential execution for the integration test suite. - For short-lived subprocess calls, the overhead of starting multiple Python processes for isolation was significantly higher than the execution time of the tests themselves. - **Impact**: Reduced total execution time by ~26% (from 4.0s to 2.9s) and ensured deterministic, ordered output. 2. **Optimize `scripts/ci_validate_repo.py`**: - Consolidated two separate file iteration loops into a single `validate_files` pass. - Implemented a "size-before-read" check using `path.stat().st_size` before calling `path.read_bytes()`. - **Impact**: Improved memory efficiency and prevented potential Out-Of-Memory (OOM) errors by ensuring large files are rejected before being read into memory. Consolidating the loop also reduces redundant file system operations. Verified both changes by running the integration tests and the validator manually.
63 lines
1.8 KiB
Python
Executable file
63 lines
1.8 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
"""
|
|
Lightweight repository sanity checks suitable for GitHub Actions.
|
|
This is intentionally NOT a compiler for MQL5 (MetaEditor isn't available on CI).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parents[1]
|
|
MQL5_DIR = REPO_ROOT / "mt5" / "MQL5"
|
|
|
|
|
|
def fail(msg: str) -> None:
|
|
print(f"ERROR: {msg}", file=sys.stderr)
|
|
raise SystemExit(1)
|
|
|
|
|
|
def iter_source_files() -> list[Path]:
|
|
if not MQL5_DIR.exists():
|
|
fail(f"Missing directory: {MQL5_DIR}")
|
|
files: list[Path] = []
|
|
for p in MQL5_DIR.rglob("*"):
|
|
if p.is_file() and p.suffix.lower() in {".mq5", ".mqh"}:
|
|
files.append(p)
|
|
if not files:
|
|
fail(f"No .mq5/.mqh files found under {MQL5_DIR}")
|
|
return sorted(files)
|
|
|
|
|
|
def validate_files(files: list[Path]) -> None:
|
|
"""⚡ Bolt: Consolidated validation loop for better performance and memory efficiency."""
|
|
for p in files:
|
|
# ⚡ Bolt: Check size first before reading into memory.
|
|
# This prevents OOM errors if a huge file is accidentally selected.
|
|
sz = p.stat().st_size
|
|
if sz > 5_000_000:
|
|
fail(f"Unexpectedly large source file (>5MB): {p.relative_to(REPO_ROOT)} ({sz} bytes)")
|
|
|
|
# ⚡ Bolt: Check for NUL bytes.
|
|
# Now it's safe to read the file as we know it's reasonably sized.
|
|
data = p.read_bytes()
|
|
if b"\x00" in data:
|
|
fail(f"NUL byte found in {p.relative_to(REPO_ROOT)}")
|
|
|
|
|
|
def main() -> int:
|
|
files = iter_source_files()
|
|
validate_files(files)
|
|
|
|
rel = [str(p.relative_to(REPO_ROOT)) for p in files]
|
|
print("OK: found source files:")
|
|
for r in rel:
|
|
print(f"- {r}")
|
|
return 0
|
|
|
|
|
|
if __name__ == "__main__":
|
|
raise SystemExit(main())
|
|
|