A fully featured risk management module including:
Advanced position sizing methods: Fixed lot, fixed percent, ATR-based, Kelly Criterion, Optimal F, and volatility-adjusted sizing
Comprehensive risk validation: Daily loss limits, drawdown management, correlation risk, symbol concentration limits
Performance tracking: For adaptive sizing algorithms
Helper methods: All properly implemented for risk calculations
Safety mechanisms: Multiple layers of protection against overleveraging
2. Complete ERMT_6.8.mq5
The final main EA file with:
Full initialization sequence: With proper error handling and cleanup
Enhanced tick processing: Optimized for performance with timer-based periodic tasks
Trading hours management: Including Friday close functionality
Alert system: Email and push notification support
Performance tracking: Automatic snapshots and reporting
System health monitoring: Memory and CPU usage checks
Comprehensive logging: Multi-level logging with file output
Helper functions: All utility functions properly implemented
Key Features Added in the Complete Version:
Enhanced Safety:
Input validation on initialization
Trading condition checks
System health monitoring
Proper cleanup on deinitialization
Professional Features:
Trading hours restrictions
Friday close functionality
Performance snapshots saved to CSV
Multi-level alerts (email/push)
Configurable logging levels
Risk Management Enhancements:
Symbol concentration limits
Portfolio correlation analysis
Adaptive position sizing based on performance
Emergency position closure triggers
User Experience:
Detailed dashboard updates
Status logging
Configuration logging on startup
Meaningful error messages
File Organization:
All seven modules are now complete and ready for compilation:
DataTypes.mqh - Complete data structures and enums
Utilities.mqh - Full utility functions library
RiskManager.mqh - Advanced risk management system
TechnicalAnalysis.mqh - (from previous conversation)
ExternalTradeManager.mqh - External trade detection and management
TradeManager.mqh - (from previous conversation)
Dashboard.mqh - (from previous conversation)
ERMT_6.8.mq5 - Main EA file with all features
The EA is now feature-complete with institutional-grade capabilities including:
Multi-strategy position sizing
Advanced risk management
External trade management
Real-time dashboard
Comprehensive logging and reporting
Performance tracking and optimization
This should compile successfully and provide a robust, professional trading system ready for testing and deployment
Overview
To fully integrate the enhanced external trade management system, updates are required to 5 out of 7 existing modules. The updates maintain backward compatibility while adding new functionality for external trade handling.
Module Update Requirements
🟢 No Updates Required (2 modules)
TechnicalAnalysis.mqh - Already provides necessary calculations
EntrySystem.mqh - Only handles EA's own entry signals
🟡 Minor Updates (2 modules)
DataTypes.mqh - Add external trade structures and fields
Utilities.mqh - Enhanced logging for external trades
🟠 Moderate Updates (3 modules)
RiskManager.mqh - Enhanced risk enforcement methods
TradeManager.mqh - Improved stop management for externals
Dashboard.mqh - Display external trade information
Integration Steps
Phase 1: Data Structures (DataTypes.mqh)
Add ENUM_EXTERNAL_STATUS enumeration
Extend ManagedTrade structure with external-specific fields
Add ExternalTradeStats structure for metrics
Update DashboardConfig with show_external flag
Key additions:
external_status - Track state of external trade
source_name - Identify where trade came from
stops_modified - Track if we modified the trade
original_sl/tp - Store original values for comparison
Phase 2: Risk Management (RiskManager.mqh)
Add EnforceRiskRulesEnhanced() method
Implement GetExternalExposure() for risk aggregation
Add UpdateExternalStats() for tracking
Enhance ValidateAndAdjustRiskExternal() method
Key features:
Separate risk calculation for external trades
Cache mechanism for performance
Statistical tracking of external positions
Smart risk adjustment without closing trades
Phase 3: Trade Management (TradeManager.mqh)
Add ApplyDefaultStopsEnhanced() with better logic
Implement OverrideExternalStops() with smart override
Create ManageExternalTrade() with different rules
Add ApplyBreakevenExternal() with wider triggers
Key features:
Smart stop override (only improve, never worsen)
Different management rules for external trades
Respect minimum broker distances
Track modification success/failure rates
Phase 4: User Interface (Dashboard.mqh)
Add CreateExternalSection() for display area
Implement UpdateExternalSection() for real-time updates
Add SetCustomText() for flexible display
Create ShowExternalTrades() toggle method
Key features:
Real-time external trade count and risk
Color-coded risk warnings
List of active external positions
Modification statistics display
Phase 5: Logging (Utilities.mqh)
Add LogExternalTrade() for detailed event logging
Create separate CSV log for external trades
Enhance GenerateReportEnhanced() with external section
Add IdentifyTradeSource() for magic number interpretation
Key features:
Separate CSV log for external trade events
Detailed tracking of all modifications
Source identification from magic numbers
Enhanced reporting with external statistics
The error "Invalid stop distance: 0.0" was occurring because the entry signals were being generated with invalid (zero) stop distances. This happened when the market volatility (ATR) value was 0 or not properly calculated.
Key Changes Made (Version 6.5.1):
Added GetValidATR() Helper Method in EntrySystem.mqh:
This method ensures we always have a valid ATR value
Includes multiple fallback mechanisms:
Direct ATR calculation if market data is invalid
0.1% of current price as a fallback
Minimum 20 pips for forex pairs
Updated All Entry Strategy Methods to use GetValidATR():
CheckMACrossover()
CheckMAPullback()
CheckMomentum()
CheckContrarian()
CheckBreakout()
CheckMeanReversion()
CheckMultiStrategy()
Enhanced Signal Validation in CheckSignal():
Added explicit check for stop_loss_distance > 0
Signal is rejected if stop distance is invalid
Better error logging to identify which strategy produced invalid signals
Improv
Parameter Confusion: The function was receiving stop distance in price units (e.g., 0.00255 for EURUSD) but treating it as if it was already in points.
Double Conversion: The code was multiplying by point size when it shouldn't have, causing the calculation to be off by a factor of 10,000 or more on 5-digit brokers.
The Fix:
I've updated the lot size calculation to properly handle the conversion:
cpp// OLD (INCORRECT):
double ticks = (stop_points * point_size) / tick_size; // Wrong!
// NEW (CORRECT):
double stop_points = stop_distance_price / point_size; // Convert to points first
double stop_ticks = stop_points * point_to_tick_ratio; // Then to ticks
Additional Improvements:
Safety Checks: Added validation to reject unreasonably high lot sizes (>1000 lots)
Enhanced Logging: More detailed debug output to diagnose issues
Dual Calculation Methods: Added a simplified calculation method for verification
Configuration Limits: Properly integrated min/max lot size limits f
I've identified and fixed the lot size calculation issue. The problem was in the formula used to calculate lot size from risk amount. Here's what was wrong and how it's fixed:
The Problem
The original calculation was producing lot sizes that were off by a factor of 100,000 (e.g., 1,315,295 lots instead of ~13 lots). This was due to an incorrect formula that wasn't properly using the tick value and tick size.
The Solution
The corrected formula now:
Uses tick value properly: The tick value represents the profit/loss in account currency for a 1 tick movement with 1 lot
Converts points to ticks: Since stop distance is in points, we convert it to ticks using point size and tick size
Calculates correctly: Lot Size = Risk Amount / (Stop Distance in Ticks × Tick Value)
Problem: EA was not opening trades during backtesting due to overly restrictive spread validation and position sizing calculation failures.
Changes Made:
1. EntrySystem.mqh - Improved Signal Validation
✅ Relaxed spread filter from fixed 10% ATR to dynamic 20-50% based on market conditions
✅ Added absolute maximum spread limit (5 pips for majors)
✅ Enhanced spread rejection logging with actual values
2. RiskManager.mqh - Fixed Position Sizing
✅ Added comprehensive logging throughout position size calculation
✅ Improved handling of minimum lot size requirements
✅ Added account balance validation before attempting trades
✅ Enhanced error messages for debugging
✅ Fixed lot size calculation for proper point value conversion
✅ Added validation for stop distance and risk amount inputs
3. ERMT_6.0.mq5 - Enhanced Configuration
✅ Increased default risk percent from 1% to 2.5% for better testing
✅ Increased max risk percent from 2% to 5%
✅ Adde
2- Compile and debug - Critical error on exit - OnDeinit
3- Fix for Entry System - Add to OnTick():
4 - ENUM_TECHNICAL_LEVEL enum in DataTypes.mqh -> other Enums and structures DataTypes.mqh v3
The Complete DataTypes Module provides the robust foundation needed for your institutional-grade risk management system, offering better trade tracking, risk analysis, and technical integration capabilities essential for professional algorithmic trading.
Moved modules to inside Advisors post-compile 1 debug; became unversioned
2 -
