koros0111/Warrior_EA
Watch
1
0
Fork
You've already forked Warrior_EA
 0
forked from animatedread/Warrior_EA
Code Pull requests Activity
Warrior_EA/Expert/Chart/AIBaseChartView.mqh

83 lines
4.5 KiB
MQL5
Raw Permalink Normal View History

refactor(chart): ChartUI is a real collaborator, not a raw-include partial (S2) Expert/AIBase/ChartUI.mqh was 869 lines of method bodies of CExpertSignalAIBase, #included after the class declaration - free to touch any of its ~500 members. First of the eleven AIBase/*.mqh partials to come out (fewest inbound edges - see the SOLID campaign session order), using the same view+adapter shape already proven for CTrainingDataView. CChartView (Expert/Chart/IChartView.mqh) is the abstract read/behaviour surface a chart-rendering collaborator needs - identity, bar/model access, the prediction cache, and the training/vote/meta scalars the panel and HUD line summarise. CAIBaseChartView is the adapter the signal owns and binds to itself (MQL5 gives a class exactly one base, so CExpertSignalAIBase cannot implement the view directly). CChartUI is the real collaborator: it owns the arrow-restore queue, the rescan queue/tally, the last-arrows-saved count and the purge-mismatch latch as its own fields (verified via grep to be touched nowhere else in Expert/), and reaches everything else - including StartChartSignalRescan, moved in from its old inline home in the header since it drives the exact same rescan state machine AdvanceChartSignalRescan drains - through the view. m_arrowSignalCache and m_signalClusterWindow stay on the signal: Training.mqh writes the cache directly every era and the training-data view already reads it, so moving it would mean rewriting Training.mqh's write sites too - out of scope here. CChartUI reaches it through four bounds-checked accessors instead of a raw member poke. All 10 public methods keep their exact signatures and become one-line forwards on the signal, so no other file's call sites change except Training.mqh's one era-end status refresh, which now reads RefreshStatusLabel() rather than reaching into CChartUI's now-private last-displayed-neuron cache directly. Verified structurally, not compiled (never compile - the operator does, in MetaEditor): brace balance checked on every touched/new file against HEAD, and the view/adapter/impl method lists cross-diffed to confirm all 59 accessors match 1:1 across the interface, the adapter declaration and the adapter body. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-23 20:03:52 -04:00
//+------------------------------------------------------------------+
//| Warrior_EA |
//| AnimateDread |
//| |
//| Adapter: CExpertSignalAIBase seen as a CChartView. |
//+------------------------------------------------------------------+
#ifndef WARRIOR_CHART_AIBASECHARTVIEW_MQH
#define WARRIOR_CHART_AIBASECHARTVIEW_MQH
#include "IChartView.mqh"
class CExpertSignalAIBase;
//+------------------------------------------------------------------+
//| THE ONE PLACE THAT KNOWS BOTH SIDES - see Training\AIBaseTrainingData.mqh for the full rationale |
//| (MQL5 gives a class exactly one base, so the signal cannot implement CChartView directly and owns |
//| one of these instead). Every method is a forward; it holds a borrowed pointer and never frees it. |
//+------------------------------------------------------------------+
class CAIBaseChartView : public CChartView
{
private:
CExpertSignalAIBase *m_owner; // BORROWED - the signal owns this object, not the reverse
public:
CAIBaseChartView(void) : m_owner(NULL) { }
~CAIBaseChartView(void) { m_owner = NULL; }
void Bind(CExpertSignalAIBase *owner) { m_owner = owner; }
virtual string Id(void) override;
virtual string FileName(void) override;
virtual string ArrowPrefix(void) override;
virtual ENUM_TIMEFRAMES Period(void) override;
virtual int Digits(void) override;
virtual string DisplayNameForChart(void) override;
virtual bool ModelLoadedFromDisk(void) override;
virtual bool TrainingComplete(void) override;
virtual bool BothDirectionsTradeable(void) override;
virtual int SignalClusterWindow(void) override;
virtual bool Stopping(void) override;
virtual datetime BarTime(const int idx) override;
virtual double BarClose(const int idx) override;
virtual int HistoryBars(void) override;
virtual int OutputNeuronsCount(void) override;
virtual bool NetReady(void) override;
virtual int AvailableBars(void) override;
virtual bool ResizeBuffers(const int barIndex) override;
virtual bool RefreshData(void) override;
virtual int ServableBars(const int want, const string context) override;
virtual void EnsureShadowNet(void) override;
virtual bool ScoreBarForRescan(const int idx, double &rawSignal, double &adjustedSignal) override;
virtual ENUM_SIGNAL ToSignal(const double value) override;
virtual int PredictionCacheSize(void) override;
virtual double PredictionAt(const int idx) override;
virtual void SetPredictionAt(const int idx, const double value) override;
virtual void ResizePredictionCache(const int size, const double fillValue) override;
fix(chart): a deployed model rescans history to rebuild its vote arrows The sidecar added in 484a9d8 restores the vote arrows from the previous session - but there was no previous session to restore from, and a deployed ensemble could never produce one. The overlay that draws the vote layer replays each member's m_overlaySigSnap, published in exactly one place: RankTiersFromOos, at pass-3 completion. A converged model runs no further eras. So after a restart every member's snapshot was empty, would never fill, the sweep had nothing to replay and the chart stayed blank permanently - no route back by any path. The chart rescan is the route: it runs the DEPLOYED net forward over history and rebuilds the per-bar cache, which is the same quantity pass 3 produces, obtained without training. It already existed for the panel's Show-Signals button; it just never handed its result to the overlay, so on the default filtered view a rescan rebuilt only the RAW per-member layer - the one that is hidden - and appeared to do nothing. - PublishOverlaySnapshotFromCache() extracted from RankTiersFromOos, so the era end and a completed rescan publish through one implementation. - A completed rescan now calls it, which also arms the sweep. - PollTraining auto-arms one rescan for a model that is converged, has no snapshot, and is on the filtered view. One-shot: a model that legitimately calls Neutral everywhere must not rescan forever chasing a snapshot that is correctly empty. On the timer, not in OnInit - it is a full feedForward per bar over up to 5000 bars and drains in the same time-boxed slices as a manual rescan. Together with the sidecar this closes both halves: the rescan covers the first session and any chart whose file was lost or invalidated by a threshold change; the sidecar covers every session after one is saved. Compile-verified in _claude_stage: 0 errors, 0 warnings. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-25 13:11:36 -04:00
virtual void PublishOverlaySnapshot(void) override;
refactor(chart): ChartUI is a real collaborator, not a raw-include partial (S2) Expert/AIBase/ChartUI.mqh was 869 lines of method bodies of CExpertSignalAIBase, #included after the class declaration - free to touch any of its ~500 members. First of the eleven AIBase/*.mqh partials to come out (fewest inbound edges - see the SOLID campaign session order), using the same view+adapter shape already proven for CTrainingDataView. CChartView (Expert/Chart/IChartView.mqh) is the abstract read/behaviour surface a chart-rendering collaborator needs - identity, bar/model access, the prediction cache, and the training/vote/meta scalars the panel and HUD line summarise. CAIBaseChartView is the adapter the signal owns and binds to itself (MQL5 gives a class exactly one base, so CExpertSignalAIBase cannot implement the view directly). CChartUI is the real collaborator: it owns the arrow-restore queue, the rescan queue/tally, the last-arrows-saved count and the purge-mismatch latch as its own fields (verified via grep to be touched nowhere else in Expert/), and reaches everything else - including StartChartSignalRescan, moved in from its old inline home in the header since it drives the exact same rescan state machine AdvanceChartSignalRescan drains - through the view. m_arrowSignalCache and m_signalClusterWindow stay on the signal: Training.mqh writes the cache directly every era and the training-data view already reads it, so moving it would mean rewriting Training.mqh's write sites too - out of scope here. CChartUI reaches it through four bounds-checked accessors instead of a raw member poke. All 10 public methods keep their exact signatures and become one-line forwards on the signal, so no other file's call sites change except Training.mqh's one era-end status refresh, which now reads RefreshStatusLabel() rather than reaching into CChartUI's now-private last-displayed-neuron cache directly. Verified structurally, not compiled (never compile - the operator does, in MetaEditor): brace balance checked on every touched/new file against HEAD, and the view/adapter/impl method lists cross-diffed to confirm all 59 accessors match 1:1 across the interface, the adapter declaration and the adapter body. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-23 20:03:52 -04:00
virtual long EraCount(void) override;
virtual long CumIsTotal(void) override;
virtual long CumIsCorrect(void) override;
virtual long CumOosTotal(void) override;
virtual long CumOosCorrect(void) override;
feat(target): delete the barrier/geometry stack - the label is the verdict Step 3 of the swing-pivot plan, whole-hog. The swing label is now the ONE target and the era verdict is precision + recall per class against the label's own base rate - no win rate, no break-even, no expectancy, no geometry anywhere in training. DELETED - Expert/Excursion/ (4), Expert/BarrierHorizon/ (4), GeometrySweep, FirstPassageLadder, Labeling/TripleBarrier.mqh (CLabelOverlap survives in Labeling/LabelOverlap.mqh), 3 test EAs. - TripleBarrierLabel + walk, fractal label, geometry derivation/scan/ adoption, exit-policy replay, excursion MI targets, the drift verdict (DIRECTION_INTELLIGENT), the recall floor, balanced-accuracy telemetry, the barrier defines, the .cfg geometry adopt (slots kept as zeros for the positional layout), the derived-geometry live-order override. - TRAINING_TARGET input/enum: direction models are always swing; META2 re-keys the meta head onto label agreement (descriptor loses its two geometry slots). REWORKED - Labels.mqh (1795 -> ~370 lines): AdvanceSwingLabelState with FINALITY-GATED CACHING - an unresolved bar (pivot pair uncommitted) is never cached, so it can never freeze as a false Neutral; training, calibration, OOS scoring and online learning all skip unresolved bars. - SDeployVerdict: significance-only; SOosTally chance = larger directional class share; pooled gate poolability = timeframe (record v2). - Purge/embargo/declustering gaps: the measured mean label resolution lag (LabelResolutionBars), not a barrier horizon. - Pool purge key + backfill DB rows: marked at the bar the label resolved on (m_labelResolveAge), not a fabricated barrier touch. - Online learning frontier: finality, not a horizon delay. - m_bestBalancedOos -> m_bestSelectionScore, m_erasSinceBestBalanced -> m_erasSinceBest, ensemble vote outcome arrays -> label arrays. STEP 4 folded in: Entry_Multiplier / SL_Mode / TP_Mode / tradingdirection are inputs again - trade management is the tester GA's search space. Fingerprints: every direction model re-keys (TGT:SWG1 now unconditional, CUT token gone); META1 -> META2. Full retrain, as planned. Compile-verified in _claude_stage: Warrior_EA + both surviving test EAs, 0 errors, 0 warnings each. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-24 20:42:31 -04:00
virtual void OosTally(int &buyPredicted, int &sellPredicted, int &buyPredictedHits, int &sellPredictedHits) override;
refactor(chart): ChartUI is a real collaborator, not a raw-include partial (S2) Expert/AIBase/ChartUI.mqh was 869 lines of method bodies of CExpertSignalAIBase, #included after the class declaration - free to touch any of its ~500 members. First of the eleven AIBase/*.mqh partials to come out (fewest inbound edges - see the SOLID campaign session order), using the same view+adapter shape already proven for CTrainingDataView. CChartView (Expert/Chart/IChartView.mqh) is the abstract read/behaviour surface a chart-rendering collaborator needs - identity, bar/model access, the prediction cache, and the training/vote/meta scalars the panel and HUD line summarise. CAIBaseChartView is the adapter the signal owns and binds to itself (MQL5 gives a class exactly one base, so CExpertSignalAIBase cannot implement the view directly). CChartUI is the real collaborator: it owns the arrow-restore queue, the rescan queue/tally, the last-arrows-saved count and the purge-mismatch latch as its own fields (verified via grep to be touched nowhere else in Expert/), and reaches everything else - including StartChartSignalRescan, moved in from its old inline home in the header since it drives the exact same rescan state machine AdvanceChartSignalRescan drains - through the view. m_arrowSignalCache and m_signalClusterWindow stay on the signal: Training.mqh writes the cache directly every era and the training-data view already reads it, so moving it would mean rewriting Training.mqh's write sites too - out of scope here. CChartUI reaches it through four bounds-checked accessors instead of a raw member poke. All 10 public methods keep their exact signatures and become one-line forwards on the signal, so no other file's call sites change except Training.mqh's one era-end status refresh, which now reads RefreshStatusLabel() rather than reaching into CChartUI's now-private last-displayed-neuron cache directly. Verified structurally, not compiled (never compile - the operator does, in MetaEditor): brace balance checked on every touched/new file against HEAD, and the view/adapter/impl method lists cross-diffed to confirm all 59 accessors match 1:1 across the interface, the adapter declaration and the adapter body. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-23 20:03:52 -04:00
virtual string PassLabel(void) override;
virtual int PassProgressPct(void) override;
virtual int OosSplitPct(void) override;
virtual int OosSamples(void) override;
virtual void ClassCounts(int &predBuy, int &predSell, int &predNeutral,
int &trueBuy, int &trueSell, int &trueNeutral) override;
virtual void OosRecallPct(int &buyRecallPct, int &sellRecallPct) override;
virtual void OosLivePrecision(int &buyPrecPct, int &buyFired, int &sellPrecPct, int &sellFired) override;
virtual double Forecast(void) override;
virtual double ErrorPct(void) override;
virtual double OosForecast(void) override;
virtual double OosErrorPct(void) override;
virtual double NetRecentAverageError(void) override;
virtual bool DisplayInference(void) override;
virtual double LiveVoteContribution(const double signal) override;
virtual double VoteCapableWeight(void) override;
virtual void PublishStatus(const string text, const bool force) override;
};
#endif // WARRIOR_CHART_AIBASECHARTVIEW_MQH
//+------------------------------------------------------------------+
Copy permalink