Build 6090 #1
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
MetaTrader 5 Platform Update Build 6090: General Improvements
https://www.metatrader5.com/en/releasenotes/terminal/2450
... and, unfortunately, the breaking of code styling "Java" style.
Rolling back MetaEditor64.exe to Build 5833 fixed the issue.
Nevertheless, I think the release should be added to this repo, maybe with a note, that it is not as shiny as the authors want it.
Thanks for your feedback.
Can you explain me exactly what is broken with Java style ? So I can check and report it to MetaQuotes.
@pintergabor wrote in #1 (comment):
Added. Thank you. https://forge.mql5.io/angevoyageur/MT5-Last-Official-Release/releases/tag/Build.6090
Thank you. I also wanted to report it to MetaQuotes, but I am not familiar with their website, and I have not known how.
1st probelm:
"Comment position up to Build 5833.png"
"Comment position after Build 6090.png"
It is ugly, especially lines 85 and 86, where the comment describes the function of a group of parameters, but it is something I could live with. Definitely NOT something you find in any Java program, where comments usually aligned with the next instruction.
2nd problem:
"Class member up to Build 5833.png"
"Class members after Build 6090.png"
Members are pushed to column 22, irrespective of any other settings. Tab size, Insert spaces, Spaces per indentation and Convert tabs to spaces settings are ignored. This bug pushed me to downgrade, because it made my code unreadable.
3rd problem (a minor one, existed in previous versions):
"Convert tab to spaces" has no effect. The styler converts indentation tabs to spaces, even if this box is unchecked.
My Option settings, for reference:
"Options - General.png"
"Options - Styler.png"
I tried other styles, and other settings, but these formattings happen the same way in all of them. It is desirable in some, for example it is not too bad in the MetaQuotes style, but they look strange in others, and definitely out of place in the Java style.
I will check and keep you posted when I will have some spare time. Thanks for your understanding.
@pintergabor wrote in #1 (comment):
I can't reproduce this issue unfortunately. If there is less than "1 tab" before the //--- it stays at the start of the line. If there is at least "1 tab" it's aligned with the code. I do have the same behaviour in 5833 and 6090. The comment is never move at the start of a line if it was aligned with code.
@pintergabor wrote in #1 (comment):
Reproduced and reported to MetaQuotes.
@pintergabor wrote in #1 (comment):
You need to disable this option too :
